This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Fix Update-ModuleManifest clears FunctionsToExport, AliasesToExport, NestedModules #373 #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the failing test, try using "Microsoft.PowerShell.Management" or "Microsoft.PowerShell.Utility", since they're nested modules used elsewhere in the file. I think throwing an error makes sense when a nested module's new manifest returns as invalid. Clearing nested modules after that sounds reasonable, though. As @edyoung commented in the related issue, would still like to merge this PR for older versions of PS. |
|
@alerickson Sounds good. I'll update my PR to take this into account today. :) |
alerickson
pushed a commit
that referenced
this pull request
Feb 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #373 .
Update : I've written a comment on the issue which essentially say that this was resolved in a recent release of PowerShell. Should I close this PR ?